search

mkopylec / charon-spring-boot-starter

Reverse proxy implementation in form of a Spring Boot starter.
Apache License 2.0
240 stars 54 forks source link

Fix for getting form body from HttpServletRequest #63

Closed cezarykluczynski closed 6 years ago

cezarykluczynski commented 6 years ago

First of all, thanks for creating this project! It got me going when Zuul and Spring Cloud Gateway didn't work for me.

This pull requests deals with the issue of form body being empty when form is send with type application/x-www-form-urlencoded. The code in this pull request is part of Spring Framework, licensed under the same license Charon is. If you think some additional copyright notices should be added to the source code itself, I'll add them.

The original code is here: https://github.com/spring-projects/spring-framework/blob/master/spring-web/src/main/java/org/springframework/http/server/ServletServerHttpRequest.java

Sorry for being able to provide only a copy-paste solution, but it actually work, and should be well tested by the Spring itself by now.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-3.04%) to 91.066% when pulling 2599ef9809bdb7a485afa5966eb7c925d2a27145 on cezarykluczynski:master into c16b97de0f0ee7ac0dbe541a36173a5ac9c4c2c7 on mkopylec:master.

mkopylec commented 6 years ago

Fixed in 3.0.2