search

mkopylec / charon-spring-boot-starter

Reverse proxy implementation in form of a Spring Boot starter.
Apache License 2.0
240 stars 54 forks source link

Incompatibility with Spring Boot 2.1 #75

Closed sdavids13 closed 5 years ago

sdavids13 commented 5 years ago

When upgrading to Spring Boot 2.1 charon no longer works. This is because Spring Boot 2.1 now auto-configures a Task Executor which disables the creation of the "charonTaskExecutor" due to the \@ConditionalBean definition but.. the ReverseProxyFilter specifically calls out the \@Qualifier("charonTaskExecutor") which wasn't loaded since Spring 2.1 already created a TaskExecutor.

As a temporary work-around you can disable the TaskExecutor auto-configuration via:

spring:
  autoconfigure:
    exclude:
      - org.springframework.boot.autoconfigure.task.TaskExecutionAutoConfiguration #Can be removed once the Charon dependency has Spring 2.1 fix
mkopylec commented 5 years ago

Thanks for reporting the issue. I will fix it soon.

mkopylec commented 5 years ago

Done in 3.0.4