mkoryak / floatThead

Fixed <thead>. Doesn't need any custom css/html. Does what position:sticky can't
https://mkoryak.github.io/floatThead/
MIT License
1.22k stars 198 forks source link

TypeScript definitions #458

Closed jmariller closed 4 years ago

jmariller commented 4 years ago

Added .d.ts file and adjusted package.json with respective reference.

mkoryak commented 4 years ago

Thanks

mkoryak commented 4 years ago

Do you need me to cut a new release with this stuff?

jmariller commented 4 years ago

My pleasure! And yes, I think it would be good to have a new release - probably a minor one is enough.

jmariller commented 4 years ago

@mkoryak I confirm a new release is needed, as I tried to uninstall/re-install the library through npm and it seems it does not reflect the latest changes.

mkoryak commented 4 years ago

I'll cut one tomorrow after the US holiday :)

On Mon, May 25, 2020, 4:48 AM jmariller notifications@github.com wrote:

@mkoryak https://github.com/mkoryak I confirm a new release is needed, as I tried to uninstall/re-install the library through npm and it seems it does not reflect the latest changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mkoryak/floatThead/pull/458#issuecomment-633458235, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5WSNYN5MFVHBLDMJ3BWTRTIWFRANCNFSM4NH2W4IA .

jmariller commented 4 years ago

No worries, thanks a lot! Enjoy the holiday :)