search

mkoryak / floatThead

Fixed <thead>. Doesn't need any custom css/html. Does what position:sticky can't
https://mkoryak.github.io/floatThead/
MIT License
1.22k stars 196 forks source link

TypeScript 4.3.5 error with version 2.2.2 #472

Closed doberkofler closed 3 years ago

doberkofler commented 3 years ago 
node_modules/floatthead/dist/jquery.floatThead.d.ts:20:67 - error TS1385: Function type notation must be parenthesized when used in a union type.

20     floatThead(action: "destroy"|"reflow"|"getRowGroups"): JQuery|() => JQuery;
mkoryak commented 3 years ago

I'll fix it in the next day or 2

On Tue, Aug 17, 2021, 11:47 PM Dieter Oberkofler @.***> wrote:

node_modules/floatthead/dist/jquery.floatThead.d.ts:20:67 - error TS1385: Function type notation must be parenthesized when used in a union type.

20 floatThead(action: "destroy"|"reflow"|"getRowGroups"): JQuery|() => JQuery;

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mkoryak/floatThead/issues/472, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5WSJSKKYCAAR5752KGTLT5MUNFANCNFSM5CLE2M5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

doberkofler commented 3 years ago

Thank you

mkoryak commented 3 years ago

i published a new version on npm too.

doberkofler commented 3 years ago

@mkoryak I'm still getting this error with version 2.2.3

node_modules/floatthead/dist/jquery.floatThead.d.ts:20:69 - error TS1385: Function type notation must be parenthesized when used in a union type.

20     floatThead(action: ("destroy"|"reflow"|"getRowGroups")): JQuery|() => JQuery;
doberkofler commented 3 years ago

Somehow the function type () => JQuery is in fact still not parenthesized

mkoryak commented 3 years ago

Do you want to submit a pr with a fix, since you have a way to get these errors and I do not?

On Fri, Aug 20, 2021, 7:45 AM Dieter Oberkofler @.***> wrote:

Somehow the function type () => JQuery is in fact still not parenthesized

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mkoryak/floatThead/issues/472#issuecomment-902634715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5WSMKEU277HVPBBVI553T5Y56DANCNFSM5CLE2M5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

doberkofler commented 3 years ago

Do you want to submit a pr with a fix, since you have a way to get these errors and I do not? … On Fri, Aug 20, 2021, 7:45 AM Dieter Oberkofler @.***> wrote: Somehow the function type () => JQuery is in fact still not parenthesized — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#472 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC5WSMKEU277HVPBBVI553T5Y56DANCNFSM5CLE2M5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

I've created a PR #473