mkotyk / mintty

Automatically exported from code.google.com/p/mintty
GNU General Public License v3.0
0 stars 0 forks source link

Answerback string does not adapt to terminal charset #263

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Options - Terminal - Answerback: enter "böh"
2. echo ^E (in UTF-8 mintty)
3. output is "b▒" - "h" is delayed

What is the expected output? What do you see instead?
"böh" - "b▒h" (with delay)

Prio: low :)

Original issue reported on code.google.com by towom...@googlemail.com on 17 May 2011 at 8:02

GoogleCodeExporter commented 8 years ago
Yep, unfortunately the config dialog still uses the "ANSI" codepage variants of 
the Windows GUI functions, so this affects all text elements on that dialog. 
But I guess the answerback is the only one where this is vaguely relevant.

Fixing this would require using the "Unicode" (i.e. UTF-16) variants of those 
APIs, storing setting strings as wchars, and converting them to and from the 
appropriate charset when interfacing with the command line, setting files, or 
the terminal.

Original comment by andy.koppe on 18 May 2011 at 7:43

GoogleCodeExporter commented 8 years ago
For a simpler fix, GUI API and storage could stay in ANSI mode, converting from 
there (rather than UTF-16) on-the-fly - or even just leaving out non-ASCII 
characters, to avoid delivery of incomplete UTF-8.

Original comment by towom...@googlemail.com on 24 May 2011 at 9:54

GoogleCodeExporter commented 8 years ago
Leaving out non-ASCII character sounds tempting.

Original comment by andy.koppe on 24 May 2011 at 7:52

GoogleCodeExporter commented 8 years ago
There is no delay anymore meanwhile, and seeing "▒" for an invalid character 
is actually OK, so I suggest to close this issue (as fixed).

Original comment by towom...@googlemail.com on 20 Mar 2014 at 12:47