search

mkoza178 / Subscription-Panel-Implementation

0 stars 0 forks source link

Header Text for "Click here" not scaling #5

Closed JLewis12 closed 6 years ago

JLewis12 commented 6 years ago

If I change the font size on the Header Tab over 14px the words and link change to converts to "..."

image

image

JLewis12 commented 6 years ago

Also alignment is off. I can not "Already a sub.." to align with "Click Here"

JLewis12 commented 6 years ago

URL = Example_1

mkoza178 commented 6 years ago

Check this preso: https://test-subscribe.oregonlive.com/Example_1MarcCopy

I deleted your formatting out and started from scratch and looks much better. I'm not sure what your formatting was doing exactly, but it caused issues.

JLewis12 commented 6 years ago

The field for the Click Here (AlreadySubscriber.LinkText:) looks to only be valid for 10 characters -

Can we please have this increased? The changes the LMG requested cause the field to display only "..." since the character count is large than 10.

image

mkoza178 commented 6 years ago

Checking on this.

mkoza178 commented 6 years ago

Jason, it looks good on https://test-subscribe.oregonlive.com/Example_OMG2 Do you agree?

JLewis12 commented 6 years ago

Good afternoon Marc,

Yes – the work around I have currently on my update does look okay. The problem with it, is that it is a global color change for the header. So Our BACK button is also picked up with the assigned color.

I want to be able to assign the variance of the 2 fields as designed if possible..

-JasonL

From: mkoza178 [mailto:notifications@github.com] Sent: Wednesday, February 14, 2018 12:30 PM To: mkoza178/Subscription-Panel-Implementation Subscription-Panel-Implementation@noreply.github.com Cc: Jason Lewis jlewis@advancelocal.com; Assign assign@noreply.github.com Subject: Re: [mkoza178/Subscription-Panel-Implementation] Header Text for "Click here" not scaling (#5)

Jason, it looks good on https://test-subscribe.oregonlive.com/Example_OMG2 Do you agree?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/mkoza178/Subscription-Panel-Implementation/issues/5#issuecomment-365735412, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AY8JZefKPH0LE7Il6xx2lfWF4WRsqkIPks5tU0I9gaJpZM4RtOpu.

mkoza178 commented 6 years ago

Right, I'll talk with the product team and see if they're open to allowing that Back button color to be changed.

JLewis12 commented 6 years ago

Please note, I am not using the "Already Subscriber" field this ticket was opened for. The "Already subscribed" that your seeing on the /OMG2 presentation is the "LOG IN" field updated and recolored as a work around..

Sorry didn't mean to close this ticket