search

mkpaz / atlantafx

Modern JavaFX CSS theme collection with additional controls.
https://mkpaz.github.io/atlantafx
MIT License
840 stars 66 forks source link

Some incompatibility with ControlsFX #8

Closed mipastgt closed 2 years ago

mipastgt commented 2 years ago

I just attempted to give AtlantaFX a try in one of my applications but I got a lot of errors (see attachment) which all originated in ControlsFX. I don't know how to react to that. Does it mean that ControlsFX cannot be used with AtlantaFX or is there anything that can be done to avoid them?

errors.txt

mkpaz commented 2 years ago

ControlsFX relies on Modena/Caspian color variables (looked-up colors), whereas AtlantaFX follows GitHub Primer color system. The errors you see mean that those looked-up colors couldn't be resolved, which is expected behavior. I don't think projects itself are not compatible, but you can't use the default ControlsFX stylesheet, because again it expected to be used with bundled OpenJFX themes only. If you want to use them together you should style each ControlsFX component using AtlantaFX color variables.

mipastgt commented 2 years ago

After investigating the issue a little bit more I still think that it would be a good idea to provide the original JavaFX color definitions, adapted to the chosen theme, as a potential fall-back for all external controls which rely on them. This is of course not a perfect solution but they could at least be used as is without having to do a full re-styling for them.

mkpaz commented 2 years ago

I think that wouldn't work because common Modena (and its derivatives) stylesheet highly use gradients and derived colors. Even if you'd changed color variables, you can also do nothing with background insets without re-styling. I don't mind including an additional module to support some third-party libs and compile it to the separate stylesheet(s) which can be optionally added to the scene. That won't happen in short/mid-term perspective though.