search

mkrakowitzer / puppet-deploy

Puppet module to deploy compressed files
11 stars 23 forks source link

Define default path for all execs. #3

Closed nodoubleg closed 10 years ago

nodoubleg commented 10 years ago

deploy::file out of the box throws path errors unless the user defines a default path for the Exec type elsewhere. A sane default should be provided here.

mkrakowitzer commented 10 years ago

I sort of feel that the default paths should be in your site.pp? As I think you would want to set this globally?

If you think it should go in this module, can I change the defaults to:

Exec { path => "/usr/bin:/usr/sbin/:/bin:/sbin" }

Our security team has an issue with paths pointing to /usr/local/bin /usr/local/sbin.

mkrakowitzer commented 10 years ago

I have update the readme file with a requirement for a default Exec to be set in the site.pp

https://github.com/mkrakowitzer/puppet-deploy/commit/f449f134e006e12610140d99d877b06e50c42217

Let me know if you think this is acceptable?

mkrakowitzer commented 10 years ago

Added this as a default, was catching a lot of people out.