search

mkrauss / ticc

Transactional Iterative Change Control
GNU General Public License v3.0
6 stars 2 forks source link

PHP version requirement unclear #1

Closed ahungry closed 8 years ago

ahungry commented 8 years ago

Should mention required PHP version in the README (the version of functional required depends on PHP 5.6), although it looks like some of the code would depend on PHP 7 features (unless string typecast works for closures, but I think thats a PHP 7 feature right?), as well as include the minimum required PHP version in the composer lockfile.

mkrauss commented 8 years ago

By "string typecast" I think you are referring to the type declarations? If that's the only thing making this require PHP 7, I would not be opposed to taking them out... What do you think? Is supporting older PHPs valuable for this?

ahungry commented 8 years ago

I like PHP7 and in the PR earlier I added it to the readme so its clear for everyone (even installing on an old thing like Ubuntu 14.04 isn't hard in the /opt directory) so I say, onward with PHP7!