Closed cmjarrett closed 10 months ago
I'm using Team objects so that I can display league standings across multiple years. While I could retrieve the historical boxscores and recreate the standings, and in fact that was my initial approach once I found the getTeamsAtWeek() api didn't work for older years. I eventually looked into each endpoint themselves to see what data was returned, and to my surprise I discovered that the endpoint simply gave me all the information I wanted (but that getHistoricalScoreboardForWeek function didn't parse and return the Team object data).
Added in #233 (v1.5.0
)
When using the Client.getTeamsAtWeek() function for league stats prior to 2018, the api fails with a 404.
(node:24828) UnhandledPromiseRejectionWarning: Error: Request failed with status code 404 at createError (C:\scratch\GitHub\GentlemensLeague\node_modules\espn-fantasy-football-api\node-dev.js:1014:15) at settle (C:\scratch\GitHub\GentlemensLeague\node_modules\espn-fantasy-football-api\node-dev.js:1289:12) at IncomingMessage.handleStreamEnd (C:\scratch\GitHub\GentlemensLeague\node_modules\espn-fantasy-football-api\node-dev.js:361:11) at IncomingMessage.emit (events.js:327:22) at endReadableNT (_stream_readable.js:1220:12) at processTicksAndRejections (internal/process/task_queues.js:84:21) (node:24828) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag
--unhandled-rejections=strict
(see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2) (node:24828) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.I've found that I can get the relevent Teams map by utilizing the same endpoint as the getHistoricalScoreboardForWeek() api, 'https://fantasy.espn.com/apis/v3/games/ffl/leagueHistory/' and then building the Teams array.
--but I thought I would at least let anyone else know that it is possible to get historical information at least to 2011.
This is the hacky temporary workaround I made in node-dev.js if anyone needs it. I'll try to mock up a pull request that isn't my hack, maybe add a getHistoricalTeamsAtWeek() function instead for those years < 2018