search

mkreiser / ESPN-Fantasy-Football-API

Connect to ESPN's fantasy football API via this JS API client for web and NodeJS. Available as an npm package.
http://espn-fantasy-football-api.s3-website.us-east-2.amazonaws.com/
GNU Lesser General Public License v3.0
296 stars 74 forks source link

Update baseURL #245

Closed CarolinaGuy89 closed 2 weeks ago

CarolinaGuy89 commented 3 weeks ago

It appears that for the 2024 season the base URL has changed.

This pull request would update the base URL. I believe this would also close issue #244.

CarolinaGuy89 commented 3 weeks ago

looking into the failed checks, absolutely a noob at this, but trying to resolve & learn. if resolve will close this commit and re-commit with solution.

taintedzodiac commented 2 weeks ago

There are also some related data structure changes that I'm noticing after changing the URL per your changes. For example, using the example from the README: various properties of the player attribute inside of objects have been moved up a level.

E.g. player.player.eligiblePositions becomes player.eligiblePositions

Perhaps some of those changes are related to the failing tests? I have not investigated further to confirm if that's the issue.

CarolinaGuy89 commented 2 weeks ago

That's a nice spot, I'll investigate that structure further this evening.

CarolinaGuy89 commented 2 weeks ago

baseURL is used in more locations that what this pull request commits.