mkreiser / ESPN-Fantasy-Football-API

Connect to ESPN's fantasy football API via this JS API client for web and NodeJS. Available as an npm package.

GNU Lesser General Public License v3.0

310 stars 78 forks source link

Open CarolinaGuy89 opened 2 months ago

CarolinaGuy89 commented 2 months ago

Correction to previous, now closed pull request #245 .

245 only modified line 13

13 | axios.defaults.baseURL = 'https://......

not realizing there existed the url existed on line 173 and 279

173 | baseURL: 'https://......
279 | baseURL: 'https://......

there is no change to the base URL for getNFLGamesForPeriod.

317 | ...... ({ baseURL: 'https://site.api.espn.com/' });

run test:integration no longer reports failed Tests locally, so I'm cautiously optimistic.

ReeceLangerock commented 2 months ago

I was having trouble getting my old code to work and landed on the same solution, fwiw.

CarolinaGuy89 commented 1 month ago

askhan04 commented 1 month ago

would be nice if this got approved. thinking about switching to the python api mentioned, doesnt look ilke this is maintained anymore?