search

mkresin / u-boot

fork of git://git.denx.de/u-boot.git with branches for different vendor implementations
Other
9 stars 7 forks source link

.asc target and build fixes for make 4.0 #1

Closed teknoraver closed 8 years ago

mkresin commented 8 years ago

I've merged you PR beside the "select only really needed nor drivers" patch. The (cF)eon driver is required as well, since both chips are used for 89x0 boards.

My 8980 board for example, has an EN56Q64-104HIP.

Thanks a lot!

mkresin commented 8 years ago

Furthermore, I'm trying to reduce changes to the TP-Link code to a minimum. As far as I can see, the only purpose of the "select only really needed nor drivers" patch is to clean-up the code and prevent the compilation of unnecessary spi drivers.

Please leave a comment, if I missed a bugfix.

teknoraver commented 8 years ago

My goal was to save a few bytes to fit in the 128 kb partition. I didn't know that some devices use Eon flash, the best thing IMHO is to apply my patch and select the Eon driver too

mkresin commented 8 years ago

Well, you know - be descriptive in your patch summary ;-).

You might want to have a look at 7ebca8bf4eadfc1cf57a00009e26a319551fe4ec. Till today, I wasn't aware of the 128kb problem and indeed, it was a bug.

I guess your patch isn't required any longer. If someone gets again into size problems, all superfluous spi drivers can be easily disabled in menuconfig.