select only needed SPI driver

mkresin / u-boot

fork of git://git.denx.de/u-boot.git with branches for different vendor implementations

Other

9 stars 7 forks source link

select only needed SPI driver #2

Closed teknoraver closed 8 years ago

mkresin commented 8 years ago

Your patch break the build:

sfddr_board.c: In function 'board_init_f':
sfddr_board.c:547:12: error: 'cmd' undeclared (first use in this function)
    sf_read(cmd,(ulong)IFX_CFG_FLASH_DDR_CFG_START_ADDR,addr_len,(u8*)&buffer,24);
            ^

As written before, I like to stay as close as possible to the TP-Link sources and even after fixing the compile error the savings are only around 2 KByte.

I don't think it's worse the work.

teknoraver commented 8 years ago

Right. it seems that the .lq build actually depends on CONFIG_SPI_FLASH_MXIC which is bad anyway

mkresin commented 8 years ago

Closing this for now. It has still issues and it only saves us 2kb.

It isn't worth the work.