search

mkristian / jar-dependencies

manage jar dependencies for ruby gems
MIT License
34 stars 19 forks source link

Fix code style for generated <gem>_jars.rb file #62

Closed paulgoetze closed 7 years ago

paulgoetze commented 7 years ago

Fixes #61.

I just removed the parentheses for all require and require_jar calls to keep it consistent and extended the regexes in the tests to match the full line.

paulgoetze commented 7 years ago

@mkristian Looks like there are issues with oraclejdk7 on Travis CI. Any ideas?

mkristian commented 7 years ago

@paulgoetze end of life reached :( - just remove it from .travis.yml

mkristian commented 7 years ago

the last test failure I saw before and do not know where this comes from. but a restart worked :)

thanks. FYI try to cut a release soon but there is another open issue I really need to look at.

paulgoetze commented 7 years ago

:+1: Thanks @mkristian for the fast merging! Looking forward to the release once the other issue is resolved.