mkristian / jar-dependencies

manage jar dependencies for ruby gems
MIT License
34 stars 19 forks source link

use JRuby::Util (available since 1.7) instead of JRuby.runtime #67

Closed kares closed 6 years ago

kares commented 6 years ago

... however class_loader_resources is only there since 9.2 still this helps, when embedded, into 9.2 stdlib to load faster

WiP on JRuby's end atm ...

mkristian commented 6 years ago

@kares ping me if you need it released. would like to add another little feature before releasing it but not today.

nice to see such a little change can improve startup in measurable fashion.

kares commented 6 years ago

thanks, no hurries. we need to coordinate other gem pieces anyway ... will ping you if we need a release.

kares commented 6 years ago

Hey Kristian, please - if you get a chance - let's have 0.3.13 pushed to we can set it up for 9.2.1

mkristian commented 6 years ago

@kares will do this evening

mkristian commented 6 years ago

still in progress, i.e. somehow gem push fails on domain resolution :(

kares commented 6 years ago

okay, thanks for the update. let me know if I can help e.g. try gem push-ing

mkristian commented 6 years ago

@kares as the gem push can not resolve rubygems.org:443 comes on top of other strange problems I face. yes, you could just checkout master, build it, push the gem and tag it with 0.4.0 (that is the version I already set). that would help me indeed. otherwise I need to just see if it is this mac or my internet or . . i.e. will do it otherwise tomorrow

kares commented 6 years ago

@mkristian okay, done - should be all good - no issues on my end:

kares@clevo:~/workspace/oss/jar-dependencies$ gem push jar-dependencies-0.4.0.gem 
Pushing gem to https://rubygems.org...
Successfully registered gem: jar-dependencies (0.4.0)
kares@clevo:~/workspace/oss/jar-dependencies$ git tag 0.4.0
kares@clevo:~/workspace/oss/jar-dependencies$ git push upstream master --tags
Total 0 (delta 0), reused 0 (delta 0)
To github.com:mkristian/jar-dependencies.git
 * [new tag]         0.4.0 -> 0.4.0

thanks for the support

mkristian commented 6 years ago

@kares thanks, very much appreciated this. I will take of failing CI, i.e. either comment fix them or not run them on travis.