search

mkristian / jar-dependencies

manage jar dependencies for ruby gems
MIT License
34 stars 19 forks source link

Revert "adjust gem post install hook to allow updating the default gem" #80

Closed headius closed 4 months ago

headius commented 4 months ago

This reverts commit 006fb2545bd11183612a85526c0891055653472a.

While the patch provided by @ccutrer did make jar-dependencies upgradable, it also caused a hard break in compatibility with earlier JRuby versions and had to eventually be reversed (jar-dependencies 0.4.2 yanked, changes to JRuby reverted). This closes the loop and reverts the changes in jar-dependencies, so we can go forward with compatible changes for now.

headius commented 4 months ago

@ccutrer I would still like to make jar-dependencies upgradable without introducing a hard dependency break! Perhaps something could be done to check JRuby's version and fall back on older logic?

I needed to revert this in order to release a fix for https://github.com/jruby/jruby/issues/7059. I'm also hoping that your "modernization" patch is benign and could safely be released in 0.4.3?