mkristian / jbundler

bundler support for jars for jruby
MIT License
210 stars 39 forks source link

jbundler does not play well with bundler-1.9.x #59

Closed mkristian closed 9 years ago

mkristian commented 9 years ago

thor gets vendored differently and causes some weird loading error:

NameError: uninitialized constant Bundler::Thor::Actions::CreateFile
  const_missing at org/jruby/RubyModule.java:2726
        Actions at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions/create_link.rb:27
           Thor at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions/create_link.rb:4
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions/create_link.rb:3
        require at org/jruby/RubyKernel.java:1071
        require at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:69
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions.rb:1
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions.rb:5
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions/empty_directory.rb:1
        require at org/jruby/RubyKernel.java:1071
        require at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:69
           Thor at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions/empty_directory.rb:2
        require at org/jruby/RubyKernel.java:1071
        require at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:69
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions/empty_directory.rb:1
        require at org/jruby/RubyKernel.java:1071
        require at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:69
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions/create_file.rb:1
        require at org/jruby/RubyKernel.java:1071
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions/create_file.rb:1
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions.rb:1
        require at org/jruby/RubyKernel.java:1071
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendor/thor/lib/thor/actions.rb:4
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendored_thor.rb:1
           load at org/jruby/RubyKernel.java:1087
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/lib/ruby/gems/shared/gems/bundler-1.9.1/lib/bundler/vendored_thor.rb:3
           load at org/jruby/RubyKernel.java:1087
         (root) at /home/christian/.rbenv/versions/jruby-1.7.19/bin/jbundle:23
mkristian commented 9 years ago

fixed via https://github.com/mkristian/jbundler/commit/20d93ab0a6d42574849f975a8dedda39af56f197 https://github.com/mkristian/jbundler/commit/1ce39b5653ef0f59f983a479faf49bc1984a9e55

garyelephant commented 8 years ago

This error occurred again with jbundler (0.9.2), bundler (1.11.2)