mkroutikov / tf-lstm-char-cnn

tensorflow rewrite of Yoon Kim's lstm-char-cnn
MIT License
215 stars 74 forks source link

Cover --EOS '' #13

Open dgerz opened 7 years ago

dgerz commented 7 years ago

Hello, thanks so much for this code! It's been really helpful for me.

The case when there's already an EOS symbol in the data doesn't seem to be covered. As I understand it, when the EOS symbol is empty it'll still append {}. Changing if eos to if eos != '' in the data reader should do the trick.

mkroutikov commented 7 years ago

pull requests are welcome!