Open mkrupczak3 opened 4 years ago
mkrupczak3
commented
4 years ago Also check out #43 for details.
I've tried once more to get this to work a bit ago (not for very long though, I've been somewhat busy / neglectful of this project lately), but couldn't immediately make sense of it.
At the very least, adding the hooks for triggering Armv8 compilation was relatively easy within the many gradle build files.
mkrupczak3
commented
3 years ago Done in Beloko + @ClockGen 's F-Droid version (read thread in issue #40 for details), still need to merge back into this one and get it on the Play Store though
See @emileb and @7dog123 's fork(s) for more detail: https://github.com/emileb/Freedoom-for-Android https://github.com/7dog123/Freedoom-for-Android
licaon-kter
commented
6 months ago @mkrupczak3 so this is fixed or? Newer Pixel devices and Android custom ROMs don't support 32bit any more :(
mkrupczak3
commented
6 months ago @licaon-kter Not in this version, I really need to get it updated and put on FDroid. I'm willing to take PRs, may be a while before I can get to it myself
licaon-kter
commented
6 months ago I just tested yesterday an arm64 build of https://f-droid.org/packages/net.nullsum.freedoom/ and will add it today to F-Droid, as the app already can't be installed on some newer arm64-only devices/ROMs that I bumped into.
It was a matter of 5 sed commands to adapt its Application.mk, SDL_spinlock.c and build.gradle, but I guess you know better than me :)
mkrupczak3
commented
6 months ago Very cool! @licaon-kter Lmk if you want to PR this repo with changes. I may remove entry in FDroid for this version as it's somewhat unmaintained
licaon-kter
commented
6 months ago @mkrupczak3 fyi https://gitlab.com/fdroid/fdroiddata/-/commit/260e04351921c0080e3a57e6da03d5d431ebc96a
Lmk if you want to PR this repo with changes.
I'm not a dev, sorry :shrug:
I've just activated what was already there since I've read your comment above https://github.com/mkrupczak3/Freedoom-for-Android/issues/41#issuecomment-948905027
Need to compile towards Armv8 before Google Play will accept any updates
I've tried to do this initially (got the initial hooks in to trigger compilation), but I found the newer versions of Google's NDK don't support the GNU c compiler (gcc)
To solve this, I downgraded my NDK version to 16b found here and re-ran build.sh to start building the c/c++ portions, but I started encountering weird build errors that I didn't have the first time around, and ones that seemingly had nothing to do with the Armv8 compilation.
I might try downgrading the NDK again, while trying to guess which particular version I used earlier to build this app.