search

mkrupczak3 / Freedoom-for-Android

Freedoom with GZDoom for Android
GNU General Public License v2.0
85 stars 16 forks source link

Cannot change brightness / contrast #44

Open kai11 opened 4 years ago

kai11 commented 4 years ago

Version from Play store Phone: moto z play, android 8.0.0 (close to stock)

Steps to reproduce: 1) launch game (doom2.wad) without addons 2) Options > Display Options 3) Adjust to max: Gamma Correction, Brightness, Contrast 4) Restart game

Actual result: Doom still too dark to play in bright room, look of the game hasn't changed

Expected result: Adjusting gamma, brightness or contrast change look of the game

mkrupczak3 commented 4 years ago

This bug bothers me too.

I haven't taken a look at this yet, mostly because this part of the code would be in the ugly part in between the game engine and the Android Java portion and I'm not too comfortable with that part of the code.

I do know that in my upstream's upstream (emilieb/beloko's delta touch), the in-game brightness setting works fine, so I'm not sure what gives. My guess would be that somehow the game engine makes a API call to the system graphics to tell it to adjust brightness setting under normal circumstances, but it likely could be missing an implementation or Android doesn't cooperate nicely with this app.

Two workarounds:

  1. Use the phone brightness setting
  2. Under graphics -> settings (or something like this?), change the sector lighting mode to "classic" or whatever. This is much less "spookydark", and has the added benefit of working much better for certain wads like Sigil.wad
mkrupczak3 commented 4 years ago

I'm not going to tag "won't fix", but I probably won't be able to fix this myself in a reasonable way, at least until #41 is completed, and I would prefer to also complete #45.

If I ever was able to rebase this project from a newer open source release of Beloko's Delta touch, this bug could get fixed, along with an update with the GZDoom engine. I should try to email him, but I'm not sure if myself I'm ready for doing this kind of in-depth work in the near future.

Others are welcome to dig through the code for now though.

mkrupczak3 commented 4 years ago

Thanks for the report, @kai11