[feat] city trend daily stacked area chart

mks-greenfield / trendr

"don't create trends, follow them"

2 stars 5 forks source link

[feat] city trend daily stacked area chart #36

Closed polinabythebay closed 8 years ago

polinabythebay commented 8 years ago

Summary of Changes

Add moment.js and string interpolation library
Refactor usTrends queries to remove unwanted queries
Add method in PolinaController to popular d3 chart with data from trend volume in the last 24 hours

SimonDing87 commented 8 years ago

Just found something minor: On lines 13-14 in usTrendQueries.js, you have some variables that aren't camelCase:

var twentyfourhoursago = moment().subtract('1','days').format(); var threehoursago = moment().subtract('3','hours').format();

I was trying to figure out how to make that pretty .diff thing here like you did in my PR, but I guess I'll figure that out later lol.

polinabythebay commented 8 years ago

oh right-- yeah I should make those camel case. Thanks for the catch! you can comment on specific lines by going to the "Files Changed" tab and clicking on one of the lines of code.

polinabythebay commented 8 years ago

@SimonDing87 alright just made the change-- will merge in a bit.