search

mks0601 / Hand4Whole_RELEASE

Official PyTorch implementation of "Accurate 3D Hand Pose Estimation for Whole-Body 3D Human Mesh Estimation", CVPRW 2022 (Oral.)
MIT License
314 stars 31 forks source link

joint_img processing. #46

Closed chenmingTHU closed 2 years ago

chenmingTHU commented 2 years ago

Hi mks0601, I find that the function process_db_coord in preprocessing.py discretizes the root-relative depth channel of joint_img: image while the discretization is also conducted in each dataset (e.g., MPI_INF_3DHP): image Is it necessary to conduct the discretization process twice? thx~

mks0601 commented 2 years ago

Why do you think there are two discretizations? There is only one

chenmingTHU commented 2 years ago

Why do you think there are two discretizations? There is only one

In MPI_INF_3DHP, the joint_img[:, 2] is discretized, then the joint_img is sent to process_db_coord function. image In process_db_coord function (line 186), the joint_img[:, 2] is discretized again? image

mks0601 commented 2 years ago

Oh.. that is a bug.. Thanks for letting me know and let me update codes now

mks0601 commented 2 years ago

I've updated codes. You can just delete that line in preprocessing.py

chenmingTHU commented 2 years ago

I've updated codes. You can just delete that line in preprocessing.py

Thanks for replying :)