search

mks0601 / TF-SimpleHumanPose

TensorFlow implementation of "Simple Baselines for Human Pose Estimation and Tracking", ECCV 2018
335 stars 90 forks source link

Confuse about get_affine_transform function #77

Open yfthu opened 2 years ago

yfthu commented 2 years ago

Hello, you have done a great job! However, I'm confused about the get_affine_transform function in mks0601/TF-SimpleHumanPose/main/gen_batch.py image

  1. when calcualte src_dir = get_dir([0, src_w -0.5], rot_rad), I think it should be src_dir = get_dir([src_w -0.5, 0], rot_rad), because the first index is width.

  2. in your get_affine_transform, if shift=0 in input, only scale[0] is used, scale[1] is not used, I think it is incorrect.

Thank you very much!

mks0601 commented 2 years ago

For both questions, you are correct. Sorry for the wrong ones :( To be honest, the codes in this repo are outdated version. You can refer to codes in my recent repo (https://github.com/mks0601/I2L-MeshNet_RELEASE/blob/4c71b89713eccfb893607963696f368f4beb9fa6/common/utils/preprocessing.py#L92).