search

mkscho63 / sta

This is an unofficial system for Foundry VTT using Modiphius's Star Trek Adventures 2d20 RPG. This system attempts to replicate the feeling of playing through an episode of the epic SciFi that is Star Trek. I am in no way associated with Modiphius.
MIT License
32 stars 33 forks source link

fix: German translations and order of disciplines #100

Open mprangenberg opened 11 months ago

mprangenberg commented 11 months ago

I fixed some of the german translations and added missing ones. I also fixed the order of the disciplines/departments, so they correspond with the character sheets (see also #25)

mprangenberg commented 11 months ago

Sorry, there seems to be a problem with selecting the disciplines. I'm investigating.

mprangenberg commented 9 months ago

Also fixed #97

mprangenberg commented 5 days ago

All of these fixes are potentially great, but I would recommend splitting this PR into multiple different ones, so that each specific change can be reviewed and accepted separately by the maintainer.

  • A german translation PR
  • The damage calculation fix PR (or review the one already submitted)
  • The discipline ordering (including an explanation for the order change)
  • Fixing the smallcraft name dropdown

The explanation for the discipline ordering is simple: they were sorted alphabetically by the English names. With translated names they were out of order. Also the the tab order wasn't right and most of all the order didn't match with the official character sheets and source books. And that last part is a real pain in the behind.

Furthermore I don't think this repository is maintained anymore. This PR is almost a year old and this is the first feedback i've gotten. Don't take this the wrong way, but maybe the maintainer can weigh in on this.