mkscho63 / sta

This is an unofficial system for Foundry VTT using Modiphius's Star Trek Adventures 2d20 RPG. This system attempts to replicate the feeling of playing through an episode of the epic SciFi that is Star Trek. I am in no way associated with Modiphius.
MIT License
32 stars 33 forks source link

Foundry v9 Compatibility #52

Closed andywingate closed 1 year ago

andywingate commented 2 years ago

Describe the bug The position of the Momentum/Threat Pools & 2 coloured bars that are part of the main toolbar is not quite right on v9 Foundry

To Reproduce Steps to reproduce the behaviour:

  1. Use the game world with v9 Foundry

Expected behaviour The Pools used to show to the left of the chat/etc bar

Screenshots If applicable, add screenshots to help explain your problem.

screenshot showing the expanded chat/scene/etc bar image

screenshot showing the collapsed toolbar image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Thanks for creating this game world!

iamthecrave commented 2 years ago

I also have this problem.

mkscho63 commented 2 years ago

This should at least be partially taken care of by the latest update. There is still an issue with the pieces not moving correctly when the sidebar is collapsed, however they should render correctly when the sidebar is expanded. I'll have to take some more time to fix the collapsed mode but I figured this was at least enough to warrant a release so that v9 is functional with STA.

andywingate commented 2 years ago

The 1.1.5 release fixed my issue - thanks!

image

iamthecrave commented 2 years ago

Yes, thank you for that and for all the work you've put in. Do you have a tip jar set up?

On Mon, Jan 3, 2022 at 7:42 AM andywingate @.***> wrote:

The 1.1.5 release fixed my issue - thanks!

[image: image] https://user-images.githubusercontent.com/749323/147931749-0b5d3011-7607-4211-ad2a-dba764c1a4df.png

— Reply to this email directly, view it on GitHub https://github.com/mkscho63/sta/issues/52#issuecomment-1004066433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUFL7BAP6Q6C7FAKIXL7W43UUGKVHANCNFSM5LDVKT5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Doug Craven Back from Japan

mkscho63 commented 2 years ago

No problem at all, glad it's working for you now. I have a page set up with Kofi for any tips :D https://ko-fi.com/mkscho63

Bluejeanjedi commented 2 years ago

I appreciate the work you've done so far. I just wanted to add that I am still experiencing the collapsing bar image from the photo above. It's not game breaking, but just wanted to add that. Thanks thus far!

mkscho63 commented 1 year ago

Should be fixed with the latest update