search

mkscho63 / sta

This is an unofficial system for Foundry VTT using Modiphius's Star Trek Adventures 2d20 RPG. This system attempts to replicate the feeling of playing through an episode of the epic SciFi that is Star Trek. I am in no way associated with Modiphius.
MIT License
32 stars 33 forks source link

DiceSoNice does not display Task and Challenge rolls for other players #71

Closed FabulistVtt closed 1 year ago

FabulistVtt commented 2 years ago

Describe the bug 3D dice are only shown to the user initiating the Task or Challenge Roll, but no other users.

To Reproduce Steps to reproduce the behavior:

  1. Install and activate Dice So Nice!
  2. Login with two users A and B
  3. Have user A open a character sheet that they control and let them perform any Task or Challenge Roll with at least 1 die.
  4. Observe display for user B
  5. You'll see no dice animation, just the chat message of the result

Expected behavior Dice rolls are shown for all users.

System

Fix You just have to change two lines in roll.js. Replace both occurances of game.dice3d.showForRoll(r) with game.dice3d.showForRoll(r, game.user, true)

FabulistVtt commented 1 year ago

It's still an issue with the recent STA 1.1.9, but the same fix still works.

mkscho63 commented 1 year ago

Including this in with 1.1.10 which is currently on develop, please let me know if the issue persists and feel free to reopen the issue. I also took this as a chance to get rid of the "double dice roll sound" issue that's been around with dice so nice. Thanks so much for the report and the solution as well (making my life easy <3 ) and I hope this fixes your problem!