search

mkschreder / juci-openwrt-feed

OpenWRT feed with all JUCI related packages.
31 stars 34 forks source link

Fixes to support building in SDK #5

Open mk-f opened 8 years ago

mk-f commented 8 years ago

I recently tried to build juci inside the OpenWRT-SDK instead inside the whole Framework. Beside stumbling upon Issue https://github.com/mkschreder/juci/issues/39 and #4 two Makefiles needed small fixes to compile trough.

mkschreder commented 8 years ago

Thanks.

I do however have a question mark around using unicode ncurses and whether that can have any side effects, but I'm adding your fix anyway because 1) libncurses is only a dependency for building luaposix and is not used by juci and 2) I'm considering removing luaposix completely some day in the future because it seems like almost an unnecessary dependency considering how little it is being used in the lua backend.

mk-f commented 8 years ago

I tried to investigate this further with no luck, to be honest i don't know why inside the SDK luaposix requires the unicode variant, it certainly doesn't when building inside the complete framework (which also does not provide ncursesw in any way as far as i see).

Package luaposix33 is missing dependencies for the following libraries:
libncursesw.so.5
Makefile:57: recipe for target '/tmp/OpenWrt-SDK-at91-legacy_gcc-5.3.0_musl-1.1.14_eabi.Linux-x86_64/bin/at91/packages/juci/luaposix33_v33.3.1-1_at91.ipk' failed

However, the autoreconf-fix is required there for me to.

mkschreder commented 8 years ago

It could be that you are somehow building unicode version and configure script of luaposix autodetects unicode lib as variant of libncurses and links to it automatically. However, the package system detects that the lib does not match the specified dependency in the package and complains about it. For example this can happen when you autodetect lua in wrong way and link to liblua5.X when your dependencies specify just liblua. Openwrt is just trying to be smart and warns you that you may have missed to specify a dependency in the package. On 1 Apr 2016 21:40, "Fabian Müller-Knapp" notifications@github.com wrote:

I tried to investigate this further with no luck, to be honest i don't know why inside the SDK luaposix requires the unicode variant, it certainly doesn't when building inside the complete framework (which also does not provide ncursesw in any way as far as i see).

Package luaposix33 is missing dependencies for the following libraries: libncursesw.so.5 Makefile:57: recipe for target '/tmp/OpenWrt-SDK-at91-legacy_gcc-5.3.0_musl-1.1.14_eabi.Linux-x86_64/bin/at91/packages/juci/luaposix33_v33.3.1-1_at91.ipk' failed

However, the autoreconf-fix is required there for me to.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/mkschreder/juci-openwrt-feed/pull/5#issuecomment-204538652

mk-f commented 8 years ago

In this case i think +libncurses +PACKAGE_libncursesw:libncursesw is a better solution