search

mkshing / ziplora-pytorch

Implementation of "ZipLoRA: Any Subject in Any Style by Effectively Merging LoRAs"
MIT License
481 stars 33 forks source link

Cosine Similarity or Simple Dot Product #9

Closed thuanz123 closed 7 months ago

thuanz123 commented 7 months ago

It seems to me that the author only use dot product between two merger vectors instead of consine similarity else the abs() function is not neccessary, also dot product match with their equation (3) better

mkshing commented 7 months ago

Fixed it on https://github.com/mkshing/ziplora-pytorch/pull/12