search

mkst / maspsx

MIT License
5 stars 4 forks source link

Missing "nop" instruction on Legacy of Kain: Soul Reaver function #101

Closed FedericoMilesi closed 2 months ago

FedericoMilesi commented 2 months ago

Hi,

I noticed this function matches 100% with the regular PsyQ configuration, but it is missing a "nop" when using the current preset for the game:

https://decomp.me/scratch/tfImt

Kind regards, Federico.

mkst commented 2 months ago

Nice bug. Should be easy to fix. maspsx doesnt currently worry about whether to place a nop if a %lo() macro is used.

    lw  $5,%lo(objectAccess+204)($2)
$L3:
    beq $5,$0,$L4
mkst commented 2 months ago

The change has been deployed to decomp.me :+1: