Open GoogleCodeExporter opened 9 years ago
Ironically I just checked in changes to remove this style, *before* I noticed
this Issue :-) Sorry. I am open to considering it. I just don't see the value
at this point. With re-entrant methods, I don't see the harm in reusing
once-constructed stateless objects, and you do save the construction AND
garbage collection thrashing. You will have to do a little more convincing to
me on this one. I'll leave the issue open for now...
Original comment by kandpwel...@gmail.com
on 30 Nov 2011 at 5:57
Re: garbage-collection thrashing. This is wild speculation. We would have to
profile to show evidence of that, and I bet that there will be no issues.
Objects are inexpensive on modern JVMs.
My position is more objective: with respect to thread-safety, it is easier to
reason about state if there is less state. This library could be reduced to the
3 items listed above. (Admittedly, my sense of aesthetic and functional style
is indeed subjective.)
Original comment by codeto...@gmail.com
on 30 Nov 2011 at 12:00
Original issue reported on code.google.com by
codeto...@gmail.com
on 30 Nov 2011 at 1:54