mktnaoi / JMAuniPicker

Neural Phase Picker for JMA unified dataset
GNU General Public License v3.0
4 stars 0 forks source link

Adding model weights to SeisBench #1

Open yetinam opened 4 months ago

yetinam commented 4 months ago

Hi @mktnaoi , I've seen your very interesting manuscript on the PhaseNet and PhaseNetWC pickers your trained on the JMA catalog. Would you be okay, if I add your trained weights to the SeisBench repository? This way, they'd be available through the from_pretrained function. I'd clearly acknowledge your work in the docstring.

mktnaoi commented 4 months ago

Hi @yetinam,

Thank you for contacting me.

We would be very grateful if you would incorporate our JMA-retrained models into Seisbench software! However, the paper in which the model is to be published is currently under review, and there is the possibility that it will be modified during the review process.

It may be better to wait, at least, for the first peer review results to come back, or to incorporate them after publication, to avoid confusion.

yetinam commented 4 months ago

Hi @mktnaoi , thanks for your quick reply! Then let's wait for the publication and we'll add the weights afterwards. Fingers crossed for the review process!