search

mktranstrum / MBAM

Code for the Manifold Boundary Approximation Method
MIT License
14 stars 5 forks source link

Modification to include tau (data space distance) #2

Closed yonatank93 closed 2 years ago

yonatank93 commented 2 years ago

I also updated some documentations and tests related to this change.

yonatank93 commented 2 years ago

And do we want to bump up the version to 0.1.0 or 1.0.0? Currently it is version 0.0.1.

yonatank93 commented 2 years ago

For the last commit above, I think it will be useful for other users if we upload this package to Pypi, so they can do pip install mbam to install this package. But in case we couldn't do it before the presentation, I removed the documentation about installation via pip so it won't mislead users.

mktranstrum commented 2 years ago

Will you please also increment the version number?

yonatank93 commented 2 years ago

@mktranstrum Would the new version number be 0.1.0 or 1.0.0?

mktranstrum commented 2 years ago

0.1.0

yonatank93 commented 2 years ago

Done. And do we want to upload this package to Pypi too, so other people can do pip install mbam?

mktranstrum commented 2 years ago

Is there any reason not to include a pip install at this point?

yonatank93 commented 2 years ago

I haven't uploaded this package to Pypi yet. I want to make sure it works first before doing that and adding pip install to README.

mktranstrum commented 2 years ago

Please do all the checks before adding pip install.

yonatank93 commented 2 years ago

Will do. So far this version passes all the tests we have. Is there anything else that I should do?

yonatank93 commented 2 years ago

@mktranstrum I added test for the parameterspacenorm flag based on your suggestion. I checked that this current version pass all the tests.