search

mkubecek / vmware-host-modules

Patches needed to build VMware (Player and Workstation) host modules against recent kernels
GNU General Public License v2.0
2.31k stars 381 forks source link

Workstation 17.0.2 and Kernel 6.4.10 (ml) fails on AlmaLinux8 "bridge.c:1416:11: implicit declaration of function 'skb_gso_segment';" #210

Closed cparg closed 1 year ago

cparg commented 1 year ago

When I try to compile branch workstation-17.0.1 with Kernel 6.4.10 I get:

  CC [M]  .../vmware-host-modules/vmmon-only/common/cpuid.o
.../vmware-host-modules/vmnet-only/bridge.c: In function 'VNetBridgeSendLargePacket':
.../vmware/vmware-host-modules/vmnet-only/bridge.c:1416:11: error: implicit declaration of function 'skb_gso_segment'; did you mean 'tcp_gso_segment'? [-Werror=implicit-function-declaration]
    segs = skb_gso_segment(skb, 0);
           ^~~~~~~~~~~~~~~
           tcp_gso_segment
.../vmware-host-modules/vmnet-only/bridge.c:1416:9: warning: assignment to 'struct sk_buff *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    segs = skb_gso_segment(skb, 0);
         ^
munix9 commented 1 year ago

https://github.com/mkubecek/vmware-host-modules/issues/209 ?

mkubecek commented 1 year ago

I'm sorry but this is getting extremely annyoing. This issue has been already reported five times and has been fixed for six days. Does noone really bother to check existing reports and check if the issue still actually exists?

munix9 commented 1 year ago

@mkubecek https://en.wikipedia.org/wiki/Groundhog_Day_(film) :-)

cparg commented 1 year ago

Hello @mkubecek,

my apologize. I did pull the latest version before checking. What am I missing?

cparg commented 1 year ago

sorry for bothering... something didn't work with the git pull before. It is fixed now, in deed!

CtrlValCanc commented 1 year ago

sorry for bothering... something didn't work with the git pull before. It is fixed now, in deed!

I had to manually go and change the file in the referenced commit, wondering why my freshly initialized repository, which I had also pulled just in case, was not functioning properly.