mkubecek / vmware-host-modules

Patches needed to build VMware (Player and Workstation) host modules against recent kernels
GNU General Public License v2.0
2.31k stars 381 forks source link

Automate DKMS setup and source code updates #214

Open rawenger opened 1 year ago

rawenger commented 1 year ago

I appreciate you setting all of this up @mkubecek, it's a total godsend. I recently had to automate the process of getting the VMware modules up and running through DKMS on a handful of machines, so I wrote this script. I've made some additions to make it as distro-agnostic as possible--let me know what you think. I've included an overview of the script's functionality at the top of dkms-setup.sh.

Edit to add: There should be no change in workflow to anyone not wishing to use DKMS.

========== COMMIT SUMMARY============

DKMS is a convenient framework for managing out-of-tree kernel modules, such as the ones in this repo. The dkms-setup.sh script will add the modules here (vmmon & vmnet, as of this writing) to the system's DKMS configuration, allowing them to be automatically rebuilt and resigned whenever the kernel is upgraded.

CHANGES:

ADDITIONS:

vasi commented 9 months ago

This is a great idea, but it doesn't work quite right for me. We checkout a different branch name, and then attempt to process dkms.conf.in, but it's no longer present!

Obviously that'd be fine if we integrated dkms.conf.in to all branches, but it makes it a bit hard to test.

vasi commented 9 months ago

I think just moving the dkms.conf generation above the branch-switch should fix this.

rawenger commented 4 months ago

Fixed! Good catch @vasi