mkubecek / vmware-host-modules

Patches needed to build VMware (Player and Workstation) host modules against recent kernels
GNU General Public License v2.0
2.24k stars 359 forks source link

opensuse Leap15.6 make vmnet-only 17.5.1 failure #262

Open bytetronic opened 1 month ago

bytetronic commented 1 month ago

Kernel: 6.4.0-150600.23.7-default (64-bit) executing make with the fix (if it is the correct thing to do?) in vmnetInt.h line 44:

#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 9, 0)
#   define dev_lock_list()    rcu_read_lock()
#   define dev_unlock_list()  rcu_read_unlock()
#else
#   define dev_lock_list()    read_lock(&dev_base_lock)
#   define dev_unlock_list()  read_unlock(&dev_base_lock)
#endif

...
CC [M] /home/xyz/Downloads/install/vmware/vmware-host-modules-workstation-17.5.1/vmnet-only/bridge.o /home/xyz/Downloads/install/vmware/vmware-host-modules-workstation-17.5.1/vmnet-only/bridge.c: In function ‘VNetBridgeSendLargePacket’: /home/xyz/Downloads/install/vmware/vmware-host-modules-workstation-17.5.1/vmnet-only/bridge.c:1418:11: error: implicit declaration of function ‘skb_gso_segment’; did you mean ‘tcp_gso_segment’? [-Werror=implicit-function-declaration] segs = skb_gso_segment(skb, 0); ^~~~~~~ tcp_gso_segment /home/xyz/Downloads/install/vmware/vmware-host-modules-workstation-17.5.1/vmnet-only/bridge.c:1418:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion] segs = skb_gso_segment(skb, 0); ^ cc1: some warnings being treated as errors

nan0desu commented 1 month ago

Can you try some of these branches? https://github.com/nan0desu/vmware-host-modules/wiki

bytetronic commented 1 month ago

Sadly neither git clone -b tmp/workstation-17.5.2-k6.9-sharishth https://github.com/nan0desu/vmware-host-modules.git nor git clone -b tmp/workstation-17.5.2-k6.9.1 https://github.com/nan0desu/vmware-host-modules.git compiles: same error as above. On my Leap 15.6 the gcc7 is installed, maybe that's a problem or some kernel stuff is missing and I need to install it?

munix9 commented 1 month ago

https://github.com/mkubecek/vmware-host-modules/issues/225

LeodeFler commented 1 month ago

I stumbled upon this: https://askubuntu.com/questions/1494239/gnu-c-compiler-gcc-version-12-2-0-was-not-found-vmware/1521670#1521670

There's a line that needs to be added to bridge.c: After the #include <linux/netdevice.h>, add

include <net/gso.h>

That fixed Workstation 17 Pro, and it finished the install and is now working.

bytetronic commented 1 month ago

Thx a lot, the #225, which is including the gso.h and my first attempt together fixed it finally!