mkuczera / react-native-haptic-feedback

React-Native Haptic Feedback for iOS with Android similar behaviour.
MIT License
855 stars 103 forks source link

Building on android fails because lambda expressions are not supported for my gradle version #115

Open bayarbotany opened 10 months ago

bayarbotany commented 10 months ago

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-haptic-feedback@2.2.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-haptic-feedback/android/src/main/java/com/mkuczera/RNReactNativeHapticFeedbackPackage.java b/node_modules/react-native-haptic-feedback/android/src/main/java/com/mkuczera/RNReactNativeHapticFeedbackPackage.java
index 945ff34..13cc1cb 100644
--- a/node_modules/react-native-haptic-feedback/android/src/main/java/com/mkuczera/RNReactNativeHapticFeedbackPackage.java
+++ b/node_modules/react-native-haptic-feedback/android/src/main/java/com/mkuczera/RNReactNativeHapticFeedbackPackage.java
@@ -1,4 +1,3 @@
-
 package com.mkuczera;

 import androidx.annotation.Nullable;
@@ -26,21 +25,24 @@ public class RNReactNativeHapticFeedbackPackage extends TurboReactPackage {

     @Override
     public ReactModuleInfoProvider getReactModuleInfoProvider() {
-        return () -> {
-            final Map<String, ReactModuleInfo> moduleInfos = new HashMap<>();
-            boolean isTurboModule = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;
-            moduleInfos.put(
-                    RNReactNativeHapticFeedbackModuleImpl.NAME,
-                    new ReactModuleInfo(
-                            RNReactNativeHapticFeedbackModuleImpl.NAME,
-                            RNReactNativeHapticFeedbackModuleImpl.NAME,
-                            false, // canOverrideExistingModule
-                            false, // needsEagerInit
-                            true, // hasConstants
-                            false, // isCxxModule
-                            isTurboModule // isTurboModule
-            ));
-            return moduleInfos;
+        return new ReactModuleInfoProvider() {
+            @Override
+            public Map<String, ReactModuleInfo> getReactModuleInfos() {
+                final Map<String, ReactModuleInfo> moduleInfos = new HashMap<>();
+                boolean isTurboModule = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;
+                moduleInfos.put(
+                        RNReactNativeHapticFeedbackModuleImpl.NAME,
+                        new ReactModuleInfo(
+                                RNReactNativeHapticFeedbackModuleImpl.NAME,
+                                RNReactNativeHapticFeedbackModuleImpl.NAME,
+                                false, // canOverrideExistingModule
+                                false, // needsEagerInit
+                                true,  // hasConstants
+                                false, // isCxxModule
+                                isTurboModule // isTurboModule
+                        ));
+                return moduleInfos;
+            }
         };
     }
 }

This issue body was partially generated by patch-package.

mkuczera commented 2 weeks ago

Hi @bayarbotany . Just catching up meanwhile. Did this issue got resolved due to latest updates maybe?