occasional-contributor commented 8 months ago

Move config from mount to volume

Motivation

Easier deployment with Portainer

How it was tested

docker compose --profile hostmcu --profile fluidd --profile mobileraker_companion up -d

COMPOSE_PROFILES=hostmcu,fluidd,mobileraker_companion docker compose up -d

Launch stack in Portainer with environment variable COMPOSE_PROFILES=hostmcu,fluidd,mobileraker_companion.

mkuf commented 8 months ago

Hey there,

I see two potential issues with this.

This would make it impossible to manage configs w/ git. Pulling prind/master into local working copies is the way a few forks as well as I personally keep the configs in line with upstream prind.
In my opinion this would add complexity as configs are not stored right in the directory where the stack has been started but deep down in the filesystem where docker creates its volumes. This may cause confusion when configs are edited via the cli (e.g. via nano) and those updates are not propagated into the running containers, even when the stack is restarted or the init service is built again because the config has been changed within the checkout location but not the docker volume.

I'm open to improve the compatibility w/ portainer but would like to keep those changes contained in the custom/docker-compose.custom.portainer.yaml file.

Furthermore, Dockerfiles should not be located in the root of this project but in a service specific directory within docker/.
For simple image builds that are supposed to run when the stack starts, it is also preferred to have them defined inline within the compose file, see the following example for reference. https://github.com/mkuf/prind/blob/64abc3028d23f7462b8cbcb5e67e6a59b17d417c/custom/docker-compose.custom.unique-uid-gid.override.yaml#L28-L38

-Markus

occasional-contributor commented 8 months ago

All very valid concerns.

I will incorporate the inlined dockerfile.

Feel free to close this PR.

I'll use my fork and keep it up-to-date with your repo. If anyone asks for compatibility with Portainer, please send them my way. I ran into quite a few issues trying to make the existing compose file for Portainer work, which is why I went down this rabbit hole.

I may create another PR once I get the custom Portainer compose file working.

mkuf / prind