search

mkuf / prind

print in docker - Deploy a containerized Klipper Stack for your 3D Printer
GNU General Public License v3.0
324 stars 82 forks source link

fix: Update gitignore #112

Closed junland closed 6 months ago

junland commented 7 months ago

This adds a git exceptions to zip files and klipper config files with the config directory that are generated when running prind.

mkuf commented 7 months ago

Can you provide an example filename from your system that would be ignored by the config/printer-*.cfg pattern?
I do not have any files matching that pattern in my config directory.

junland commented 7 months ago

Sure, something like this:

        config/printer-20240202_182533.cfg
        config/printer-20240202_201438.cfg
        config/printer-20240202_202852.cfg
        config/printer-20240204_210704.cfg
        config/printer-20240204_212522.cfg
        config/printer-20240204_223107.cfg
        config/printer-20240208_232126.cfg
        config/printer-20240208_235310.cfg
        config/printer-20240209_185309.cfg
        config/printer-20240211_030720.cfg
        config/printer-20240211_030736.cfg
mkuf commented 6 months ago

This would also target config/printer-simulavr.cfg, which is required by this project.

I suggest adding this change to your local working copy if you need it but at the current time I do not see any benefit from merging this into main.

Thanks for reaching out. -Markus

junland commented 6 months ago

Gotcha, no worries! Thank you for reviewing!