mkulesh / microMathematics

microMathematics Plus - Extended visual calculator
GNU General Public License v3.0
561 stars 68 forks source link

Contrasted Text? #114

Closed goyalyashpal closed 1 year ago

goyalyashpal commented 2 years ago

any thoughts about having text to be having slightly different bg than the equations.

it may create additional burden for theming - and without having much gain. so, i am just thinking out loud and want to hear what you and other people think

reference: theming of .ipynb files in vscodium and on google's online editor

mkulesh commented 2 years ago

Hi @yashpalgoyal1304, thank you for the issue. There is no problem either improve the existing themes or add a new theme. You can find all available themes here: https://github.com/mkulesh/microMathematics/tree/master/app/src/main/res/values, files with name theme_*.xml. If you have Android Studio installed, please feel free to play with these themes. If you will find a new theme, just open a pull request with a new theme_*.xml file, I will merge it and include into the app.

any thoughts about having text to be having slightly different bg than the equations

It is also possible, but the theme template shall be expanded programmatically: we need to add a new theme parameter like textBackgroundColor and apply it in the class https://github.com/mkulesh/microMathematics/blob/master/app/src/main/java/com/mkulesh/micromath/formula/TextFragment.java

mkulesh commented 1 year ago

Hi @yashpalgoyal1304 If you have any idea for a new color scheme, you can make a design in any graphical editor (better in Inkskape on order to be able directly access the colors of the objects) and I can add a new color theme based on this design.

goyalyashpal commented 1 year ago

hi! thanks for the offer, but i closed this as i thought that i won't be able to work on it.