Oreo icon shape - Githubissues

mkulesh / microMathematics

microMathematics Plus - Extended visual calculator

GNU General Public License v3.0

566 stars 68 forks source link

Oreo icon shape #72

Closed 532910 closed 6 years ago

532910 commented 6 years ago

Please add support for icon shape https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive.html https://material.io/guidelines/style/icons.html

mkulesh commented 6 years ago

Hi @c-e-p-x-u-o sorry for a late response. I Implemented your proposal. Please download the latest autobuild and test how does it now look.

mkulesh commented 6 years ago

Please note: The autobuild https://github.com/mkulesh/microMathematics/raw/autobuild/autobuild/microMathematics-v2.17.2.apk is not signed, i.e is not compatible with app version installed from any market. Just uninstall official version of the app before you install autobuild APK

532910 commented 6 years ago

Yes, sorry. I realized it just after the deleted comment was written (:

What do you think about this concept: round square Or the same but in reverse color: blue -> white, white -> blue

mkulesh commented 6 years ago

thanks for idea, I will try it

532910 commented 6 years ago

the white penta-star inside is smaller in my imagination than on my images.

mkulesh commented 6 years ago

I changed icon to this: ic_launcher In my opinion, It looks really contrast on both dark and light backgrounds as well as on O and pre-O devices. Please test the latest autobuild.

532910 commented 6 years ago

I think there should be no edge:

mkulesh commented 6 years ago

yes, you are right, for adaptive icon I shall use a square shape instead of round one. Now, I changed it like this: ic_launcher_adapt Please take a look. PS. Thanks for testing. I only have a pure Android without third-party launchers, and, therefore, can only test in a standard environment.

532910 commented 6 years ago

Nice! But the center of the star should be a bit lower. See red marks on the second row.
all

532910 commented 6 years ago

You mean you have a pure Android 8.x (oreo) and it's impossible to change icon shape on it?

I'm using LineageOS 15.1 with Trebuchet launcher.

mkulesh commented 6 years ago

Yes, I currently use Nokia 8 with pure Android 8.1 as a reference device. Here, I can not change the icon style.

Thank you for such a detailed test. Now, I centered the star exactly on the center of a circle shape, see https://github.com/mkulesh/microMathematics/blob/master/images/launcher/source.svg For a square shape, the star may look as not centered since it is non-symmetric, but in this case it is an optical effect.

532910 commented 6 years ago

Awesome!

mkulesh commented 6 years ago

Ready to be delivered with version 2.17.2