mkulesh / onpc

Enhanced Music Controller
GNU General Public License v3.0
133 stars 22 forks source link

Englarge Mute Button #314

Closed nick16 closed 1 month ago

nick16 commented 3 months ago

Since I only the use mute button within the app (since I use the phone hard buttons for volume control), I would like it be easier for me to mute my receiver. There's been times where I miss the mute button, and since there's a lot of wasted space on the screen, primarily in the center, I would like to replace the center image with a mute button that fits the entire space, so I can mute my receiver without looking at my phone.

mkulesh commented 2 months ago

Hi @nick16, thank you for a proposal and sorry for a late response since my vacation :)

Unfortunately, a large mute button does not correspond to my design rules.

Therefore, I implemented a slightly different solution:

Please find a new test build here: https://1drv.ms/u/s!At2sh2-YDyGFg0JYEkzJw52cQYqZ

nick16 commented 2 months ago

Just gave your test build a run, and the mute button satisfies my request. I love it! Thanks.

mkulesh commented 2 months ago

To be merged into premium version

nick16 commented 2 months ago

To add onto this idea, what if when the user swipes up on the album cover it increases the volume and swiping down decreases volume. This makes adjusting the volume even easier.

mkulesh commented 2 months ago

Hi @nick16

To add onto this idea, what if when the user swipes up on the album cover it increases the volume and swiping down decreases volume. This makes adjusting the volume even easier.

Unfortunately it is not possible. I am not able to change the master volume during the scrolling since this operation is slowly on the receiver site. Therefore I send the command after the scrolling is finished and use the progress bar for it in order to indicate the resulting volume before the command is sent. Without such an indication (like in your proposal) there is a possibility to set the master volume to a too high value that may damage the acoustic system...

mkulesh commented 2 months ago

Released in version 2.14.0

nick16 commented 2 months ago

Thats too bad.. To clarify, I was thinking when the user swipes up a single time, it would increase the volume 0.5. Im not proposing a slider, rather a swipe motion to change the volume 0.5 at a time.

mkulesh commented 2 months ago

Hi @nick16, if you use Android, you can use the hardware volume buttons to increase/decrease the volume. It is more consistent than the swipe on the album image...