mkulesh / onpc

Enhanced Music Controller
GNU General Public License v3.0
133 stars 22 forks source link

Give option to use Friendly Name for Media Inputs #9

Closed mrlad closed 5 years ago

mrlad commented 5 years ago

Could you please give us the option in settings to show the friendly name that is mapped to the default media input?

For example, I've mapped

mkulesh commented 5 years ago

Hi @mrlad, for the media inputs, there are two name version:

The simplest way is just improve the text for these constants.

Or do you mean a king of editor where some "alternative" names can be given for all these inputs?

mrlad commented 5 years ago

Hi @mkulesh,

some names are provided by Onkyo device in the ReceiverInformation message

Yes, those are the standard default names.

The simplest way is just improve the text for these constants

Don't think this solves the problem. Many users will have unique names/setups and no matter how descriptive you make it, you'll never be able to solve everyone's configuration.

Or do you mean a king of editor where some "alternative" names

No. The Integra setup lets you rename the input to a friendly name. These are the alternate names I'm referring to.

The cleanest solution is to pull the friendly name from the receiver. The official Integra Remote 3 app is able to pull the friendly name from the receiver and display it so it is possible via the API.

mkulesh commented 5 years ago

Hi @mrlad, thank you for explanation. Do you propose just replace in-app string resources by the names provided in the ReceiverInformation message or add application setting like "Use input selector names from receiver"?

mrlad commented 5 years ago

Hi @mkulesh ,

I think having an application setting is the best approach. Some people may not want to use the friendly name. Although to be honest, if they created a friendly name I'm not sure why they wouldn't want to see it by default, but inevitably, someone won't want to see it so a setting should make everyone happy.

mkulesh commented 5 years ago

Hi @mrlad, I added new two-way switch into the "Device input selector" setting screen. It it is switched-on (default setting), than the names provided by Onkyo device will be used in the MEDIA tab instead of build-in names. The setting screen itself is not changed - I still use here the build-in names. Could you please test it with the latest autobuild from https://github.com/mkulesh/onpc/raw/autobuild/autobuild/onpc-v0.7.apk?

friendly_selector_name

mrlad commented 5 years ago

Hi @mkulesh, changing this selection caused the friendly name to show under the Media but it didn't change the name shown in settings. This is working as you'd expect in this test drop correct?

mkulesh commented 5 years ago

Hi @mrlad, you are right, I expected no changes for the name shown in settings. Yesterday... Today, howeve, the "Input Selectors" setting screen is also expanded and now, if you changes "Friendly selector name" switch, the names in this settings screen shall also be adapted. I hope this issue is now fully implemented. Please re-test using the latest build it and close the issue if everything is OK.

mrlad commented 5 years ago

@mkulesh , friendly name in the settings are working properly for both main zone and zone 2.

mkulesh commented 5 years ago

Released in v0.7

mrlad commented 5 years ago

Confirmed fixed.