search

mkumatag / openbmc-automation

Test OpenBMC Distribution, moved to - https://github.com/openbmc/openbmc-test-automation
Apache License 2.0
5 stars 11 forks source link

Added test case for testing syslog function of open bmc. #46

Closed rahulmah closed 8 years ago

rahulmah commented 8 years ago

This change is Reviewable

causten commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

_a discussion (no related file):_ I like your test suite. I think you should add a reboot test to ensure the ip of the syslog stays intact

Does the code indicate if the syslog server is NOT a server?

Comments from Reviewable

rahulmah commented 8 years ago

@causten : I have made changes to use global variable and also added test case to syslog setting persistency. Please mark this as LGTM so that it can me merged.

causten commented 8 years ago
:lgtm:
Previously, rahulmah (Rahul Maheshwari) wrote… > @causten : I have made changes to use global variable and also added test case to syslog setting persistency. Please mark this as LGTM so that it can me merged. >

Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

causten commented 8 years ago

syslog code has been merged, this code can now be merged too

causten commented 8 years ago

Reviewed 5 of 5 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable