search

mkumatag / openbmc-automation

Test OpenBMC Distribution, moved to - https://github.com/openbmc/openbmc-test-automation
Apache License 2.0
5 stars 11 forks source link

Added test case to verify IP address type #52

Closed rahulmah closed 8 years ago

rahulmah commented 8 years ago

This change is Reviewable

causten commented 8 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

_tests/test_networkd.robot, line 143 [r2] (raw file):_


Get IP Address type with valid interface

This test case is assuming the interface is set to Static? Rules of test cases require that the TC is not reliant on other test cases. You should force the value then read it back. OR check if it is either 'STATIC' or 'DYNAMIC'

Comments from Reviewable

rahulmah commented 8 years ago

@causten : I have modified the test case to first force static ip address and then read address type back. Now it should looks good. Please mark it LGTM, if it looks good.

causten commented 8 years ago

I think the networkd code needs a rewrite now that we are better with robot. The test cases should not hardcode IP's and MAC's. When you hardcode the MAC I no longer can run the test suite on multiple systems at the same time. Having said that the changes specific to this pull request are a step in the right direction :lgtm:

Previously, rahulmah (Rahul Maheshwari) wrote… > @causten : I have modified the test case to first force static ip address and then read address type back. Now it should looks good. Please mark it LGTM, if it looks good. >

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

causten commented 8 years ago

Reviewed 1 of 1 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable