Use signals to dispose of the children of Viewports in RGSS1

mkxp-z / mkxp-z

Open-source cross-platform player for (some) RPG Maker XP / VX / VX Ace games. A very heavily modified fork of mkxp. RGSS on steroids with a stupid name.

https://github.com/mkxp-z/mkxp-z/wiki

GNU General Public License v2.0

140 stars 39 forks source link

Use signals to dispose of the children of Viewports in RGSS1 #149

Closed WaywardHeart closed 1 month ago

WaywardHeart commented 5 months ago

~~I don't really know if that dynamic cast is how I should be doing this, but it works.~~

Fixes #142

Edit: I've looked into it some more and that is, in fact, what dynamic casting is for. Good.

WaywardHeart commented 5 months ago

I forgot to actually add the changes before amending for my last force push. Not an important change, just removing an obsolete finalizer.

Splendide-Imaginarius commented 5 months ago

Maruno on Discord said:

I can confirm that this build no longer produces console messages when disposing stuff (unless I was extremely lucky with my testing).