Closed pbodsk closed 5 years ago
@nickskull, @chriscombs, @jakobmygind
I've tried implementing the feature we talked about on slack today so you can bypass the hockey validation.
Granted, the check is a bit crude...just another unless
outside the existing one but it seems to work. If you have better suggestions I'm more than willing to listen 😄
I think the actual hockey check shouldn’t be performed at all?
@nickskull you mean completely remove it so it is never executed?
@pbodsk yeah, I mean, what’s the point of doing the check if you ignore the result in the end?
We don't ignore it always.
If disable_hockey_version_check
is set to true, then we ignore it.
But if disable_hockey_version_check
is not set (the default), then we still do the check and fail if pre-conditions are invalid.
unless disable_hockey_version_check
unless (Version.new(xcode_version) >= Version.new(hockey_version)) && (xcode_build > hockey_build)
valid = false
warning_message = """#{key}: Xcode version #{xcode_version} (#{xcode_build}) is lower or equal than the one on Hockey #{hockey_version} (#{hockey_build})."""
message +="#{warning_message} \n"
puts yellow "|- #{warning_message}"
end
end
Of course :D I meant only when disabling the check
which allows you to bypass Hockey version validation