ml-archive / bitrise-step-nodes-custom-script

Custom Bitrise step for the iOS CI system
MIT License
2 stars 6 forks source link

Feature/code obfuscation #25

Closed kjoneandrei closed 5 years ago

dominik-hadl commented 5 years ago

It looks ok to me, just one question regarding de-obfuscation - eg. I think we need to expose the mapping file somehow (at least on Bitrise) so that we have a chance at deobfuscating crash reports, otherwise they will be all rendered pointless.

kjoneandrei commented 5 years ago

true, how will we expose that file? the file gets created when the obfuscate command gets ran

dominik-hadl commented 5 years ago

See https://devcenter.bitrise.io/builds/build-artifacts-online/

kjoneandrei commented 5 years ago

Found out the project needs to be signed before obfuscation to assure that it compiles, since the obfuscation step will try to build the project