ml-archive / bitrise-step-nodes-custom-script

Custom Bitrise step for the iOS CI system
MIT License
2 stars 6 forks source link

CI_VERSION is ignored as it is not parsed in step.sh #26

Closed kjoneandrei closed 5 years ago

kjoneandrei commented 5 years ago

Check if we have ci-version set correctly

if [ -z "${CI_VERSION}" ]; then
    # not set, fallback to default CI version
    CI_VERSION=$DEFAULT_CI_VERSION
fi

will always fail and set the CI_VERSION to default as CI_VERSION is an enviroment variable set later.

As a consequence the wrong parse project settings version will be used

chriscombs commented 5 years ago

The parse_project_settings step always uses the default because thats the step that assigns the CI_VERSION env var. We need the step.sh script to parse the ci version out of the yml by itself instead of relying on the env var.

dominik-hadl commented 5 years ago

Fixed by #31