search

ml-archive / forms

Tools for working with Forms in Vapor
MIT License
7 stars 0 forks source link

Replaces old convenience init with more flexible 1 #21

Closed siemensikkema closed 6 years ago

siemensikkema commented 6 years ago

See header doc for example. I used this in Urbanest and I think it makes sense in a broader context. It replaces the old convenience so it is a breaking change but we can just bump the minor version. What do you think?

codecov[bot] commented 6 years ago

Codecov Report

Merging #21 into master will decrease coverage by 1.99%. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #21   +/-   ##
======================================
- Coverage    73.6%   71.6%   -2%     
======================================
  Files          21      21           
  Lines         466     479   +13     
  Branches       23      23           
======================================
  Hits          343     343           
- Misses        123     136   +13
Impacted Files Coverage Δ
Sources/Forms/Fieldset/ViewData+fieldSet.swift 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ae1c08...076833f. Read the comment docs.